Migration with is not idempotent when combining default=null and Maybe type#1534
Open
danbroooks wants to merge 1 commit intoyesodweb:masterfrom
Open
Migration with is not idempotent when combining default=null and Maybe type#1534danbroooks wants to merge 1 commit intoyesodweb:masterfrom
danbroooks wants to merge 1 commit intoyesodweb:masterfrom
Conversation
danbroooks
changed the title
danbroooks
force-pushed
the
non-idempotent-migration-maybe-text
branch
from
7bd8eb2 to
ea4069e
Compare
danbroooks
commented
May 22, 2024
| fit "is idempotent (default text example)" $ runDb $ do | ||
| void $ runMigrationSilent migrationWithDefaultMaybeText | ||
| again <- getMigration migrationWithDefaultMaybeText | ||
| liftIO $ again @?= ["ALTER TABLE \"text_maybe_default\" ALTER COLUMN \"field2\" SET DEFAULT null"] |
Contributor
Author
There was a problem hiding this comment.
In this case, the test should be:
liftIO $ again @?= []
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreation for issue described in #1535
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog